Skip to content

Increase config.py coverage - #427

Merged
mbernier merged 1 commit into
sendgrid:masterfrom
jefersondaniel:master
Oct 24, 2017
Merged

Increase config.py coverage#427
mbernier merged 1 commit into
sendgrid:masterfrom
jefersondaniel:master

Conversation

@jefersondaniel

Copy link
Copy Markdown
Contributor

Addresses #420

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 23, 2017
@SendGridDX

SendGridDX commented Oct 23, 2017

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov-io

codecov-io commented Oct 24, 2017

Copy link
Copy Markdown

Codecov Report

Merging #427 into master will increase coverage by 0.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #427     +/-   ##
=========================================
+ Coverage   81.98%   82.38%   +0.4%     
=========================================
  Files           9        9             
  Lines         999      999             
  Branches      160      160             
=========================================
+ Hits          819      823      +4     
+ Misses         90       86      -4     
  Partials       90       90
Impacted Files Coverage Δ
sendgrid/helpers/inbound/config.py 93.54% <0%> (+12.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4302bff...2feecae. Read the comment docs.

@mbernier

Copy link
Copy Markdown
Contributor

Beautiful! Thank you!

@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 24, 2017
@mbernier
mbernier merged commit 0c422e2 into sendgrid:master Oct 24, 2017
@thinkingserious

Copy link
Copy Markdown
Contributor

Hello @jefersondaniel,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants