Provide utf-8 as encoding explicitly when opening text files - #414
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
==========================================
- Coverage 88.41% 88.26% -0.16%
==========================================
Files 30 30
Lines 924 929 +5
Branches 110 112 +2
==========================================
+ Hits 817 820 +3
Misses 53 53
- Partials 54 56 +2
Continue to review full report at Codecov.
|
2050868 to
fb3cda1
Compare
|
Looks good. You can also do |
|
Good point, thanks. Done :) |
cc64dc9 to
d6d83b5
Compare
|
We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
|
Hello @rshest, |
When opening text files in few places, the code relies on system default encoding being set to UTF-8.
This is safe enough in general, but there are certain corner cases like #379, where default one is e.g. ASCII (for whatever reason).
The pull request changes code to use UTF-8 encoding explicitly, without relying on the system defaults.
EDIT: There is another commit fixing a unit test (
test_asm_display_group_limit), since that was failing the build, coming from master rebase.EDIT2: The "reduced" code coverage is because of added import statements - so this is a false positive in fact.