Skip to content

Sync up with the official version#10

Merged
kanekv merged 4 commits into
sendgrid:masterfrom
dmcguire81:master
Jan 29, 2013
Merged

Sync up with the official version#10
kanekv merged 4 commits into
sendgrid:masterfrom
dmcguire81:master

Conversation

@dmcguire81

Copy link
Copy Markdown

I have one of Kane's changes, and also implemented support for the &user feature and did a filter setting defect-fix. You should check with Kane if he has anything else outstanding.

@dmcguire81

Copy link
Copy Markdown
Author

P.S.: Do you think we can get a new version on PyPI with the fix? I'm dogfooding the package for an acceptance test project, and I'll need to make the build server construct and serve the patched egg, otherwise, so I just need a heads up. Thanks.

kanekv pushed a commit that referenced this pull request Jan 29, 2013
Sync up with the official version
@kanekv kanekv merged commit 899c3b6 into sendgrid:master Jan 29, 2013
@theycallmeswift

Copy link
Copy Markdown
Contributor

I'm actually unclear on this pull, @davidmcguire mind clarifying?

1. What is the user param for and where is that documented?

We need to update the README to include this and if it's not in the docs, those need to be updated too.

2. Does changing the secure param to **opts, is that going to be a breaking change for anyone who upgrades?

I don't think this is an issue, but just double checking.

3. Did this get published to Pypi?

If so, this requires a version bump.

@dmcguire81

Copy link
Copy Markdown
Author
  1. Here http://sendgrid.com/docs/API_Reference/Customer_Subuser_API/statistics.html. It's not advertised as a generic authentication feature, but it's implemented that way. Basically, users can make requests on their subuser's account, and an admin (SendGrid employee) can make a request on behalf of anyone.
  2. This won't be a breaking change, no.
  3. Not yet.

@theycallmeswift

Copy link
Copy Markdown
Contributor

Ah, I see. I feel like this is actually relatively inconsistent compared to the rest of the libraries we have. The expected behavior is that you send as whatever user is authenticated, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants