Skip to content

test: Test to check year in license file - #66

Merged
mbernier merged 1 commit into
sendgrid:masterfrom
pushkyn:test-release-date-range
Oct 31, 2017
Merged

test: Test to check year in license file#66
mbernier merged 1 commit into
sendgrid:masterfrom
pushkyn:test-release-date-range

Conversation

@pushkyn

@pushkyn pushkyn commented Oct 28, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #61

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
mithunsasidharan
mithunsasidharan reviewed Oct 29, 2017
View reviewed changes
Comment thread src/test/java/com/sendgrid/LicenseTest.java Outdated
@Test
public void testLicenseShouldHaveCorrectYear() throws IOException {
String copyrightText = null;
try (BufferedReader br = new BufferedReader(new FileReader("./LICENSE.txt"))) {

@mithunsasidharan mithunsasidharan Oct 29, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid file name

@pushkyn pushkyn Oct 29, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 29, 2017
@mbernier

mbernier commented Oct 31, 2017

Copy link
Copy Markdown
Contributor

Thank you!

@mbernier
mbernier merged commit 39ee7b5 into sendgrid:master Oct 31, 2017
@thinkingserious

thinkingserious commented Oct 31, 2017

Copy link
Copy Markdown
Contributor

Hello @pushkyn,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@mbernier mbernier mentioned this pull request Nov 1, 2017
Closed
6 tasks
JyotsnaC pushed a commit to JyotsnaC/java-http-client that referenced this pull request Nov 3, 2017
Matt Bernier
Merge pull request sendgrid#66 from pushkyn/test-release-date-range
ad93da8 
Test to check year in license file
@eshanholtz eshanholtz changed the title Test to check year in license file test: Test to check year in license file Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mithunsasidharan mithunsasidharan mithunsasidharan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a unittest to check the license.md file date range

4 participants

@pushkyn @mbernier @thinkingserious @mithunsasidharan