Skip to content

Added unittest to check for specific repo files - #65

Merged
mbernier merged 1 commit into
sendgrid:masterfrom
mptap:add-test-files-exist
Oct 29, 2017
Merged

Added unittest to check for specific repo files#65
mbernier merged 1 commit into
sendgrid:masterfrom
mptap:add-test-files-exist

Conversation

@mptap

@mptap mptap commented Oct 28, 2017 •
edited by mbernier
Loading

Copy link
Copy Markdown

Fixes #62

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@mbernier edit: changed to #62 on the link at the top

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@mptap mptap mentioned this pull request Oct 28, 2017
Closed
@mptap
mptap force-pushed the add-test-files-exist branch from 8f42184 to 93a70b6 Compare October 28, 2017 20:35
@mbernier

mbernier commented Oct 29, 2017

Copy link
Copy Markdown
Contributor

This seems to be doing the job! Thank you!

@mbernier

mbernier commented Oct 29, 2017

Copy link
Copy Markdown
Contributor

TestRequiredFilesExist > checkUseCases FAILED
java.lang.AssertionError at TestRequiredFilesExist.java:90
TestRequiredFilesExist > checkDockerExists FAILED
java.lang.AssertionError at TestRequiredFilesExist.java:13
TestRequiredFilesExist > checkDockerComposeExists FAILED
java.lang.AssertionError at TestRequiredFilesExist.java:20
TestRequiredFilesExist > checkEnvSampleExists FAILED
java.lang.AssertionError at TestRequiredFilesExist.java:25
TestRequiredFilesExist > checkCodeClimateExists FAILED
java.lang.AssertionError at TestRequiredFilesExist.java:40

@mbernier mbernier added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 29, 2017
@mbernier
mbernier merged commit ce30af0 into sendgrid:master Oct 29, 2017
@thinkingserious

thinkingserious commented Oct 29, 2017

Copy link
Copy Markdown
Contributor

Hello @mptap,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

JyotsnaC pushed a commit to JyotsnaC/java-http-client that referenced this pull request Nov 3, 2017
Matt Bernier
Merge pull request sendgrid#65 from mptap/add-test-files-exist
ade0e2a 
Added unittest to check for specific repo files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add unittest to check for specific repo files

3 participants

@mptap @mbernier @thinkingserious