feat: Allow setting both apache http client and test parameters - #22
Conversation
|
@thinkingserious Hi, do you have any ETA to merge this? |
|
Hello @maximn, No ETA yet, but generally issues gain priority in our backlog with additional +1's or a PR. When we receive a PR, that provides the biggest jump in priority. However, we are currently working an upgrade to the library and before I start coding that, I will try to clear out any outstanding PRs. I will begin work on the refactor when I get at least 3 thumbs up on it. If you have a moment, I would greatly appreciate your feedback. With Best Regards, Elmer |
|
Hi, there're few thumbs up now. This is a very simple and backward compatible change. Please have a look. The problem is that currently we can't set up the http client that we use to send to SendGrid. This will help us a lot. |
|
Thank you for the clarification! I just need one more thumbs up on the refactor, I'm hoping that will happen this week. |
|
There're quite a few thumbs. Do you have an ETA? |
|
LGTM |
Remove oraclejdk7 from .travis.yml as Travis does not support it anymore Details: travis-ci/travis-ci#7884 (comment)
Remove oraclejdk7 from .travis.yml
Update README.md
Moved Mockito to test dependency.
added code of conduct
|
Hi, do you have any ETA to merge this? |
More SEO Friendly Section links
Update readme - moved logo to top, added license and other badges
update contributing.md - fix typo
Fix gradle error
add github PR template
Java 7 support in gradle being depreciated
add usage.md
Added TROUBLESHOOTING.md
change year for the license file
…http-client into client_another_ctor
Allow setting both `apache http client` and `test` parameters
apache http client and test parametersapache http client and test parameters
#21