Skip to content

Support Nokia N9#49

Merged
selwin merged 2 commits into
selwin:masterfrom
hongquan:master
Jan 6, 2016
Merged

Support Nokia N9#49
selwin merged 2 commits into
selwin:masterfrom
hongquan:master

Conversation

@hongquan

@hongquan hongquan commented Dec 1, 2015

Copy link
Copy Markdown
Contributor

This is to fix #33

@selwin

selwin commented Dec 2, 2015

Copy link
Copy Markdown
Owner

If we do this, we'll then have to add every other Nokia device models into MOBILE_DEVICE_FAMILIES so I don't think this is a good idea. Is there anything else that we can use to identify this as a mobile device?

The existence of NokiaBrowser string in the user agent perhaps?

@hongquan

hongquan commented Dec 2, 2015

Copy link
Copy Markdown
Contributor Author

Or NokiaBrowser and Mobile

@selwin

selwin commented Dec 2, 2015

Copy link
Copy Markdown
Owner

Sounds good to me. Could you please update your PR?

Nokia N9 (MeeGo) and N900 (Maemo)
@hongquan

hongquan commented Dec 7, 2015

Copy link
Copy Markdown
Contributor Author

@selwin I updated the PR.

selwin added a commit that referenced this pull request Jan 6, 2016
@selwin selwin merged commit 8fd709c into selwin:master Jan 6, 2016
@selwin

selwin commented Jan 6, 2016

Copy link
Copy Markdown
Owner

@hongquan thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to detect Nokia N9 browser

2 participants