Skip to content

Fix logging of cascading scan name #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
J12934 merged 2 commits into from
Jan 11, 2022
Merged

Fix logging of cascading scan name #923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7abd19e
Fix logging of cascading scan name
malexmave Jan 11, 2022
07fd264
Log the final created scan name as well
malexmave Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions hooks/cascading-scans/hook/scan-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,20 +135,21 @@ export function mergeInheritedSelector(parentSelector: LabelSelector = {}, ruleS
}

export async function startSubsequentSecureCodeBoxScan(scan: Scan) {
console.log(`Starting Scan ${scan.metadata.name}`);
console.log(`Starting Scan ${scan.metadata.generateName}`);

try {
// Submitting the Scan to the kubernetes api
await k8sApiCRD.createNamespacedCustomObject(
const createdScan = await k8sApiCRD.createNamespacedCustomObject(
"execution.securecodebox.io",
"v1",
namespace,
"scans",
scan,
"false"
);
console.log(`-> Created scan ${createdScan.body["metadata"].name}`)
} catch (error) {
console.error(`Failed to start Scan ${scan.metadata.name}`);
console.error(`Failed to start Scan ${scan.metadata.generateName}`);
console.error(error);
}
}
Expand Down