Update Nuclei cascading rule to include protocol information and allow alternative HTTP ports#920
Merged
Merged
Conversation
malexmave
added a commit
that referenced
this pull request
Jan 10, 2022
Analogous to #920, this commit splits the cascading rule for ZAP into two: one for HTTP and one for HTTPS. This allows it to cover HTTP(S) services on nonstandard ports. This also requires adding the port as an extra parameter. Signed-off-by: Max Maass <max.maass@iteratec.com>
3 tasks
The nuclei rule had problems because it omitted the protocol and port information. This commit splits it into two separate rules, one for http and one for https. This should make it more robust. Signed-off-by: Max Maass <max.maass@iteratec.com>
0d94008 to
61416bd
Compare
J12934
approved these changes
Jan 10, 2022
This was referenced Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nuclei rule had problems because it omitted the protocol and port information (#713). This PR splits it into two separate rules, one for http and one for https. This should make it more robust.
An alternative that would only require a single rule would be the following:
However, this would no longer allow us to trigger on alternative HTTP(S) ports like 8080, 8443, etc., since they have alternative service descriptors (
http-proxy, ...) which would break the URL when based on{{attributes.service}}as the protocol selector. I thus opted to split it into two separate rules.Closes #713.
Checklist
npm testruns for the whole project.