Migrate make to task#3539
Merged
Merged
Conversation
✅ Deploy Preview for docs-securecodebox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR completes the repository-wide migration from Makefiles to Taskfiles (go-task/task) for build/test automation across scanners, hooks, operator, auto-discovery, SDKs, and documentation, and updates CI/workflows/docs accordingly.
Changes:
- Removed Makefile-based automation (
Makefile,*.mk, component Makefiles) and replaced/expanded Taskfile equivalents across the repo. - Updated GitHub workflows to install and use
taskfor docs generation and CI build/test steps. - Updated contributor documentation/ADR references from
make ...totask ....
Reviewed changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test-base.mk | Removed shared Make-based test harness. |
| sdk.mk | Removed SDK Make include (replaced by Taskfiles). |
| prerequisites.mk | Removed Make prerequisites checks. |
| env-paths.mk | Removed Make path indirection (replaced by Task vars). |
| scanners.mk | Removed scanner Make include. |
| hooks.mk | Removed hook Make include. |
| Makefile | Removed root Make entrypoints; Taskfile now owns these commands. |
| Taskfile.yaml | Root Taskfile expanded (paths/helm docs/lint/new-scanner/etc). |
| scanners/Taskfile.yaml | Scanner orchestration updated (setup tasks, requires vars, etc). |
| scanners/ffuf/Taskfile.yaml | Taskfile version bump. |
| scanners/git-repo-scanner/Taskfile.yaml | Taskfile version bump. |
| scanners/gitleaks/Taskfile.yaml | Taskfile version bump. |
| scanners/kube-hunter/Taskfile.yaml | Taskfile version bump. |
| scanners/ncrack/Taskfile.yaml | Taskfile version bump. |
| scanners/nikto/Taskfile.yaml | Taskfile version bump. |
| scanners/nmap/Taskfile.yaml | Taskfile version bump. |
| scanners/nuclei/Taskfile.yaml | Taskfile version bump. |
| scanners/screenshooter/Taskfile.yaml | Taskfile version bump. |
| scanners/semgrep/Taskfile.yaml | Taskfile version bump. |
| scanners/ssh-audit/Taskfile.yaml | Taskfile version bump. |
| scanners/sslyze/Taskfile.yaml | Taskfile version bump. |
| scanners/subfinder/Taskfile.yaml | Taskfile version bump. |
| scanners/test-scan/Taskfile.yaml | Taskfile version bump. |
| scanners/trivy/Taskfile.yaml | Taskfile version bump. |
| scanners/trivy-sbom/Taskfile.yaml | Taskfile version bump. |
| scanners/whatweb/Taskfile.yaml | Taskfile version bump. |
| scanners/wpscan/Taskfile.yaml | Taskfile version bump. |
| scanners/zap-automation-framework/Taskfile.yaml | Taskfile version bump. |
| hooks/Taskfile.yaml | Hook orchestration updated (setup tasks, requires vars, etc). |
| hooks/cascading-scans/Taskfile.yaml | Taskfile version bump. |
| hooks/finding-post-processing/Taskfile.yaml | Taskfile version bump. |
| hooks/generic-webhook/Taskfile.yaml | Taskfile version bump. |
| hooks/notification/Taskfile.yaml | Taskfile version bump. |
| hooks/persistence-azure-monitor/Taskfile.yaml | Taskfile version bump. |
| hooks/persistence-defectdojo/Taskfile.yaml | Taskfile version bump. |
| hooks/persistence-dependencytrack/Taskfile.yaml | Taskfile version bump. |
| hooks/persistence-elastic/Taskfile.yaml | Taskfile version bump. |
| hooks/update-field-hook/Taskfile.yaml | Taskfile version bump. |
| parser-sdk/nodejs/Makefile | Removed Makefile entrypoint for parser SDK. |
| parser-sdk/nodejs/Taskfile.yaml | Added Taskfile entrypoint for parser SDK build/export/kind-import. |
| hook-sdk/nodejs/Makefile | Removed Makefile entrypoint for hook SDK. |
| hook-sdk/nodejs/Taskfile.yaml | Added Taskfile entrypoint for hook SDK build/export/kind-import. |
| operator/Makefile | Removed operator Makefile entrypoint. |
| operator/Taskfile.yaml | Added operator Taskfile (codegen, envtest, tests, docker, helm deploy). |
| auto-discovery/kubernetes/Makefile | Removed auto-discovery (kubernetes) Makefile entrypoint. |
| auto-discovery/kubernetes/Taskfile.yaml | Added auto-discovery (kubernetes) Taskfile (tests/build/docker/etc). |
| auto-discovery/kubernetes/pull-secret-extractor/Taskfile.yaml | Taskfile version bump. |
| auto-discovery/cloud-aws/Makefile | Removed auto-discovery (cloud-aws) Makefile entrypoint. |
| auto-discovery/cloud-aws/Taskfile.yaml | Added auto-discovery (cloud-aws) Taskfile (tests/build/docker/helm). |
| demo-targets/Makefile | Removed demo-targets Makefile entrypoint. |
| demo-targets/Taskfile.yaml | Added/expanded demo-targets Taskfile (incl. helm-unit-tests loop). |
| documentation/Makefile | Removed documentation Makefile entrypoint. |
| documentation/Taskfile.yaml | Added documentation Taskfile (puml/clean/install/start). |
| documentation/docs/contributing/test-concept/operator-test.md | Updated instructions from make → task. |
| documentation/docs/contributing/operator.md | Updated instructions from make → task. |
| documentation/docs/contributing/integrating-a-scanner/integrating-a-scanner.md | Updated scanner creation command to task. |
| documentation/docs/contributing/integrating-a-hook/makefile.md | Removed deprecated Makefile doc page. |
| documentation/docs/architecture/09_architecture_decisions/adr_0018.md | Marked ADR as superseded by Task migration + note. |
| .templates/new-scanner/Taskfile.yaml | Template Taskfile version bump. |
| .github/workflows/ci.yaml | Switched CI steps from make/manual task install → setup-task + task commands. |
| .github/workflows/helm-docs.yaml | Installed Task and swapped make docs generation → task. |
| .github/workflows/scb-bot.yaml | Installed Task and swapped make docs generation → task. |
Review notes (blocking):
scanners/Taskfile.yaml(lines ~109–116):test:setup:parser-depsalways runsbun installeven whenparserUsesNpmDependenciesis"false"(nopackage.json), which will fail for non-Node parsers. Make the command conditional (similar tohooks/Taskfile.yaml), or only run the task when the parser has apackage.json.Taskfile.yaml(root) (lines ~199–206):create-new-scanneruses a shell preconditionsh: '[ -n "{{ .NAME }}" ]'. With Go templates, an unset variable can render as<no value>and still satisfy-n, so this may not reliably block missingNAME. Preferrequires: { vars: [NAME] }(as used inhooks/Taskfile.yaml/scanners/Taskfile.yaml) or use a safer default/empty check.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Reet00
reviewed
Mar 5, 2026
Contributor
Reet00
left a comment
There was a problem hiding this comment.
Looks good so far :)
It would be nice to have 1 command that builds and deploys the operator for local development, like task deploy for the scanners. As i have seen it, we have to start kind-import and helm-deploy separately
a858c0c to
b45703c
Compare
8532f11 to
b9b5731
Compare
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: p4trickweiss <p4trick.weiss@gmail.com>
|
J12934
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the migration from Make to Task as the project's build automation tool.
(closes #3159)
Checklist