Fix/nuclei tests - #1419
Merged
Merged
Conversation
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
…n-test scan Since Nuclei uses a custom resolver it does not benefit from domain search specs in kubedns Signed-off-by: Rami Souai <rami.souai@iteratec.com>
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| eslint | 1 | 1 | 0.58s | ||
| ✅ SPELL | misspell | 3 | 0 | 0.04s | |
| ✅ YAML | prettier | 2 | 0 | 0.76s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
J12934
approved these changes
Oct 27, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1342 #1162
Description
Using the format http://..svc leads to DNS errors with nuclei, since it uses its own DNS resolver. Instead, we use Full Qualified Domain Name with the format http://..svc.cluster.local more info
Checklist