Improves the integration-tests makefile process for scanners#1033
Merged
Conversation
installed within the scanners directory This removes the dependency on tests/integration package.json Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
when it's not necessary Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
also changed it in the corresponding files This is done to fix the file dependency issue in CI Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
This is to make the CI run successfully again. And is rather irrelevant since these tests will be migrated in later PRs Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This is done to include the fix to semgrep integration-tests Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…anner folders Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
The limitation of the GitHub API rate does not allow to run these tests in a reasonable amount of time Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
The cascading scan hook tests already include this use-case Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Weltraumschaf
approved these changes
Mar 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the scanners` dependency on integration tests located in tests/integration
scanners.mkis changed to make use of the integration-tests located in the $(scanner-name)/integration-tests folderAs a side effect of the transition to the use of makefile. We've had to have a two copies of helpers.js. One in scanners/ folder and the other in tests/integration. The one in tests/integration can be deleted after the migration of the hooks integration tests is complete. (This is why the codeclimate check is unhappy)
Description
Checklist
npm testruns for the whole project.