Skip to content

Supports for local functions in translator #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdpython merged 6 commits into from
Feb 19, 2025
Merged

Supports for local functions in translator #96

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5ce3275
fix suffix
xadupre Feb 18, 2025
d7c89f2
one fix
xadupre Feb 19, 2025
da08d73
fix
xadupre Feb 19, 2025
67eb1c2
fix ut
xadupre Feb 19, 2025
00d0e7b
fix ir_version
xadupre Feb 19, 2025
922a3a0
doc
xadupre Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@xadupre
xadupre committed Feb 19, 2025
commit da08d731578984720027ed93f5c7eec72108a120
7 changes: 5 additions & 2 deletions onnx_array_api/translate_api/builder_emitter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,13 @@ def _emit_node(self, **kwargs: Dict[str, Any]) -> List[str]:
raise NotImplementedError("Graph attribute not supported yet.")
args.append(f"{k}={vatt}")

outs = ", ".join(map(self._clean_result_name, outputs))
cleaned_outputs = list(map(self._clean_result_name, outputs))
outs = ", ".join(cleaned_outputs)
inps = ", ".join(map(self._clean_result_name, inputs))
op_type = self._emit_node_type(op_type, domain)
sdomain = "" if not domain else f", domain={domain!r}"
# Let's add output names to make it easier to debug.
soutputs = f", outputs={cleaned_outputs}"
sdomain = soutputs if not domain else f", domain={domain!r}{soutputs}"
if args:
sargs = ", ".join(args)
if inps:
Expand Down