Skip to content

Pin package versions centrally using Directory.Build.targets#1293

Merged
jrusbatch merged 2 commits into
devfrom
feature/nuget-pinning
Oct 11, 2018
Merged

Pin package versions centrally using Directory.Build.targets#1293
jrusbatch merged 2 commits into
devfrom
feature/nuget-pinning

Conversation

@filipw
Copy link
Copy Markdown
Member

@filipw filipw commented Oct 4, 2018

To avoid package versions diverging between projects.

@filipw filipw requested review from jrusbatch and khellang October 4, 2018 12:57
@filipw
Copy link
Copy Markdown
Member Author

filipw commented Oct 11, 2018

ping @khellang @jrusbatch

Copy link
Copy Markdown
Member

@khellang khellang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No idea what the Paket.Restore.targets changes are though...

Comment thread Directory.Build.targets
<PackageReference Update="Autofac" Version="4.6.2" />
<PackageReference Update="Autofac.Mef" Version="4.0.0" />
<PackageReference Update="McMaster.Extensions.CommandLineUtils" Version="2.2.5" />
<PackageReference Update="Microsoft.CodeAnalysis.Scripting" Version="2.9.0" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: indentation

Copy link
Copy Markdown
Member

@jrusbatch jrusbatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrusbatch jrusbatch merged commit b12ed13 into dev Oct 11, 2018
@khellang khellang deleted the feature/nuget-pinning branch October 11, 2018 22:50
@filipw
Copy link
Copy Markdown
Member Author

filipw commented Oct 12, 2018

No idea what the Paket.Restore.targets changes are though...

yeah.. new version of Paket did them automatically and apparently that file should be in source control ¯_(ツ)_/¯ fsprojects/Paket#2840 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants