Skip to content

Fixes #1172 and #1173#1177

Merged
glennblock merged 2 commits into
scriptcs:devfrom
glennblock:travisfix
Sep 6, 2016
Merged

Fixes #1172 and #1173#1177
glennblock merged 2 commits into
scriptcs:devfrom
glennblock:travisfix

Conversation

@glennblock

Copy link
Copy Markdown
Contributor
  • Locks Travis mono build version to 4.2.3.
  • Fixes cp command.

@glennblock

Copy link
Copy Markdown
Contributor Author

OK so pinning to Mono 4.2.3 seems to have worked. The 2 tests failing are because of the cp command.

@glennblock

Copy link
Copy Markdown
Contributor Author

doh, my case sensitivity was wrong.

@glennblock

Copy link
Copy Markdown
Contributor Author

Yay!

@glennblock

glennblock commented Sep 6, 2016

Copy link
Copy Markdown
Contributor Author

@adamralph @ilovezfs pinning indeed fixed it for now.

@glennblock glennblock merged commit b8b689d into scriptcs:dev Sep 6, 2016
@glennblock glennblock deleted the travisfix branch September 6, 2016 07:59
@ilovezfs

ilovezfs commented Sep 6, 2016

Copy link
Copy Markdown

@glennblock nice work :)

@glennblock

Copy link
Copy Markdown
Contributor Author

@ilovezfs it won't fix it for brew though as you said because of the mono version.

@glennblock

glennblock commented Sep 6, 2016

Copy link
Copy Markdown
Contributor Author

@ilovezfs based on where all the acceptance tests are failing in the code, it really looks like it is a very specific issue related to how mono is returning the stdout stream. The likelihood is that scriptcs itself will work fine. Do you want me to create for you the brew build.sh file?

@ilovezfs

ilovezfs commented Sep 6, 2016

Copy link
Copy Markdown

@glennblock that would be great.

@glennblock

Copy link
Copy Markdown
Contributor Author

@ilovezfs just committed build_brew.sh to dev, and master. It doesn't affect our release, so there was no problem just committing to master.

@glennblock

Copy link
Copy Markdown
Contributor Author

Yippee!

screen shot 2016-09-06 at 1 32 33 am

@ilovezfs

ilovezfs commented Sep 6, 2016

Copy link
Copy Markdown

@glennblock awesome 💚

@glennblock

Copy link
Copy Markdown
Contributor Author

Thanks for the help!
On Tue, Sep 6, 2016 at 2:14 AM ilovezfs notifications@github.com wrote:

@glennblock https://github.com/glennblock awesome 💚


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1177 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAInRJGY4sQVMDYbEddyWFpzkbsEfIfEks5qnS7agaJpZM4J1i36
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants