Skip to content

ChocolateyInstall.ps1 should not restore Roslyn packages#1140

Merged
glennblock merged 1 commit into
scriptcs:devfrom
jrusbatch:chocolatey-script
Mar 23, 2016
Merged

ChocolateyInstall.ps1 should not restore Roslyn packages#1140
glennblock merged 1 commit into
scriptcs:devfrom
jrusbatch:chocolatey-script

Conversation

@jrusbatch

@jrusbatch jrusbatch commented Mar 22, 2016

Copy link
Copy Markdown
Member

Previous versions required that Roslyn be restored from NuGet. This is no longer necessary, since we now distribute a more recent release of Roslyn in our package.

Steps to test:

  1. Run build.cmd.
  2. Navigate to artifacts\Release.
  3. Run choco install scriptcs -source .

Scriptcs v0.16.0 should install without error.

@jrusbatch
ChocolateyInstall.ps1 should not restore Roslyn
cfdfa6f 
Previous versions required that Roslyn be restored from NuGet. This is
no longer necessary, since we now distribute a more recent release of
Roslyn in our package.
@glennblock

glennblock commented Mar 23, 2016

Copy link
Copy Markdown
Contributor

Checking now

@glennblock glennblock merged commit f2506d5 into scriptcs:dev Mar 23, 2016
@glennblock

glennblock commented Mar 23, 2016

Copy link
Copy Markdown
Contributor

Verified, thanks @jrusbatch!

@adamralph

adamralph commented Mar 26, 2016

Copy link
Copy Markdown
Contributor

Are we complying with the license for https://www.nuget.org/packages/Roslyn.Compilers.CSharp by distributing it with scriptcs?

@glennblock

glennblock commented Mar 26, 2016

Copy link
Copy Markdown
Contributor

The new Roslyn bits are OSS . We can distribute it.
On Sat, Mar 26, 2016 at 9:04 AM Adam Ralph notifications@github.com wrote:

Are we complying with the license for
https://www.nuget.org/packages/Roslyn.Compilers.CSharp by distributing it
with scriptcs?

—
You are receiving this because you modified the open/close state.

Reply to this email directly or view it on GitHub
#1140 (comment)

@adamralph

adamralph commented Mar 26, 2016

Copy link
Copy Markdown
Contributor

OK, so this is fine for the dev branch.

Our master branch has been distributing the old Roslyn bits for some time now (with the redundant restore in the chocolatey script) but that is a separate issue.

@glennblock

glennblock commented Mar 26, 2016

Copy link
Copy Markdown
Contributor

Really? I thought those are the newer bits.
On Sat, Mar 26, 2016 at 9:35 AM Adam Ralph notifications@github.com wrote:

OK, so this is fine for the dev branch.

Our master branch has been distributing the old Roslyn bits for some time
now (with the redundant restore in the chocolatey script) but that is a
separate issue.

—
You are receiving this because you modified the open/close state.

Reply to this email directly or view it on GitHub
#1140 (comment)

@adamralph

adamralph commented Mar 26, 2016

Copy link
Copy Markdown
Contributor

We haven't yet released a version using anything newer than the old CTP with the restrictive license.

@jrusbatch jrusbatch deleted the chocolatey-script branch March 26, 2016 17:15
@glennblock glennblock added this to the v0.16 milestone Apr 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.16

Development

Successfully merging this pull request may close these issues.

3 participants

@jrusbatch @glennblock @adamralph