Skip to content

Provide editing capabilities using Mono.Terminal.GetLine. #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filipw merged 3 commits into from
Nov 14, 2015
Merged

Provide editing capabilities using Mono.Terminal.GetLine. #1119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e84a769
Provide editing capabilities using Mono.Terminal.GetLine.
migueldeicaza Nov 5, 2015
3bcf559
Renaming getline.cs, removing tabs / fixing formatting, fixing ctrl+c…
glennblock Nov 9, 2015
68567a6
Reverting references
glennblock Nov 9, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ScriptCs.Contracts/IConsole.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public interface IConsole

void WriteLine(string value);

string ReadLine();
string ReadLine(string prompt);

void Clear();

Expand Down
3 changes: 1 addition & 2 deletions src/ScriptCs.Core/ReplCommands/ExitCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ public object Execute(IRepl repl, object[] args)

while (!responseIsValid)
{
_console.Write("Are you sure you wish to exit? (y/n): ");
response = (_console.ReadLine() ?? string.Empty).ToLowerInvariant();
response = (_console.ReadLine("Are you sure you wish to exit? (y/n):") ?? string.Empty).ToLowerInvariant();
responseIsValid = response == "y" || response == "n";
}

Expand Down
4 changes: 2 additions & 2 deletions src/ScriptCs.Hosting/FileConsole.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ public void WriteLine(string value)
this.AppendLine(value);
}

public string ReadLine()
public string ReadLine(string prompt)

@filipw filipw Nov 9, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there prompt if it's not being used?

@glennblock glennblock Nov 9, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used.
On Mon, Nov 9, 2015 at 7:10 AM Filip W notifications@github.com wrote:

In src/ScriptCs.Hosting/FileConsole.cs
#1119 (comment):

@@ -35,9 +35,9 @@ public void WriteLine(string value)
this.AppendLine(value);
}

  •    public string ReadLine()

  •    public string ReadLine(string prompt)

why is there prompt if it's not being used?

—
Reply to this email directly or view it on GitHub
https://github.com/scriptcs/scriptcs/pull/1119/files#r44284665.

@filipw filipw Nov 9, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whole method is

        public string ReadLine(string prompt)
        {
            var line = _innerConsole.ReadLine("");
            this.AppendLine(line);
            return line;
        }

@khellang khellang Nov 9, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just not used in the FileConsole.

@filipw filipw Nov 9, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah now i see, ok!

@glennblock glennblock Nov 9, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, it is part of the general interface
On Mon, Nov 9, 2015 at 7:51 AM Kristian Hellang notifications@github.com
wrote:

In src/ScriptCs.Hosting/FileConsole.cs
#1119 (comment):

@@ -35,9 +35,9 @@ public void WriteLine(string value)
this.AppendLine(value);
}

  •    public string ReadLine()

  •    public string ReadLine(string prompt)

It's just not used in the FileConsole.

—
Reply to this email directly or view it on GitHub
https://github.com/scriptcs/scriptcs/pull/1119/files#r44290238.

{
var line = _innerConsole.ReadLine();
var line = _innerConsole.ReadLine("");
this.AppendLine(line);
return line;
}
Expand Down
Loading