made Namespaces collection immutable and relevant methods virtual #1040#1041
made Namespaces collection immutable and relevant methods virtual #1040#1041lukebuehler wants to merge 3 commits into
Conversation
|
refs #1040 |
|
@lukebuehler can you please rebase your branch onto the upstream dev branch? |
|
@adamralph done |
|
@adamralph oh crap, did I just mess up the rebase? |
|
I'm mobile right now, but I'll take a look asap. The easiest thing to do to On 16:05, Fri, 8 May 2015 Lukas Buhler notifications@github.com wrote:
|
|
It looks like you did a merge instead of a rebase. Not to worry, I'll cherry pick your commit and merge it manually. As I say, for future ref, if you always work off a feature branch, you'll avoid this problem. |
|
Instead of merging manually I raised another PR containing your commit - #1042 |
Small breaking change if people changed
IScriptExecutor.Namespacesdirectly or kept a reference to it somewhere else (assuming it will be update when the namespaces change)