Skip to content

add issue stats badges to readme - #1002

Merged
filipw merged 1 commit into
devfrom
issue-stats
Mar 29, 2015
Merged

add issue stats badges to readme#1002
filipw merged 1 commit into
devfrom
issue-stats

Conversation

@adamralph

Copy link
Copy Markdown
Contributor

No description provided.

filipw added a commit that referenced this pull request Mar 29, 2015
add issue stats badges to readme
@filipw
filipw merged commit a56ff4a into dev Mar 29, 2015
@filipw
filipw deleted the issue-stats branch March 29, 2015 00:38
@filipw

filipw commented Mar 29, 2015

Copy link
Copy Markdown
Member

btw, why was this branch part of the upstream?

@adamralph

Copy link
Copy Markdown
Contributor Author

It's because I made the change using the GitHub UI. I don't think it has an
option to use your own fork for the branch.

On 01:39, Sun, 29 Mar 2015 Filip W notifications@github.com wrote:

btw, why was this branch part of the upstream?


Reply to this email directly or view it on GitHub
#1002 (comment).

@khellang

Copy link
Copy Markdown
Member

That's the same reason the version bump landed on an upstream branch. Didn't realize we were so careful about polluting upstream with temporary branches. IIRC, you can use the GH UI from the fork to do a PR. I'll remember to do that next time.

@filipw

filipw commented Mar 30, 2015

Copy link
Copy Markdown
Member

I don't think it's that important to be honest but I think it's a nice practice since it looks much nicer to the outsiders.

Just compare Nancy (https://github.com/NancyFx/Nancy/branches/all) to MVC (https://github.com/aspnet/Mvc/branches/all) 😄

@adamralph

Copy link
Copy Markdown
Contributor Author

👍 In this case it's not so important, but generally I abhor upstream branches for this very reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants