Skip to content

Add support for API version 3 - #13

Closed
jbt wants to merge 3 commits into
scottgonzalez:masterfrom
jbt:master
Closed

Add support for API version 3#13
jbt wants to merge 3 commits into
scottgonzalez:masterfrom
jbt:master

Conversation

@jbt

@jbt jbt commented Feb 8, 2013

Copy link
Copy Markdown

Sorry it's a bit messy with the triple-nested map, but I've tried to keep it in concordance with the existing coding style. This seems to work whenever I test it.

Comment thread lib/browserstack.js Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, in v3 you can request a flat list:

http://api.browserstack.com/3/browsers?flat=true

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh shiny, that wasn't there yesterday when I was double-checking this. Well in that case 95% of the messy stuff can be deleted.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I asked them to add it 😉

@scottgonzalez

Copy link
Copy Markdown
Owner

@jbt You should've left a comment when you updated this. There are no notifications for new commits, so I thought this was still waiting on you... I'll review this soon.

@jbt

jbt commented Mar 18, 2013

Copy link
Copy Markdown
Author

Oops, sorry!

@scottgonzalez

Copy link
Copy Markdown
Owner

Can you update the docs for the new data structure in v3?

I think this covers everything.
@jbt

jbt commented Mar 18, 2013

Copy link
Copy Markdown
Author

There we go, think that's everything updated in the readme now.

Comment thread readme.md

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to add "(null for desktop browsers)" to the description of device as well.

See https://github.com/browserstack/api/tree/v3#output-1

@scottgonzalez

Copy link
Copy Markdown
Owner

There are issues with this implementation which were brought up by @Krinkle and not addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants