Skip to content

Autofind homebrew installation path#115

Merged
AaronDJohnson merged 3 commits into
scikit-sparse:masterfrom
matospiso:autofind-brew-installation
Apr 16, 2024
Merged

Autofind homebrew installation path#115
AaronDJohnson merged 3 commits into
scikit-sparse:masterfrom
matospiso:autofind-brew-installation

Conversation

@matospiso
Copy link
Copy Markdown

[setup.py] check for Homebrew-installed SuiteSparse and automatically construct correct Include and Library paths

… construct correct Include and Library paths
@matospiso
Copy link
Copy Markdown
Author

matospiso commented Apr 16, 2024

@AaronDJohnson the tests are failing for Python 3.6, because in that version subprocess.run() does not yet support capture_output argument (added in 3.7, see docs). I can make it backward compatible, but it might be less elegant.

@matospiso
Copy link
Copy Markdown
Author

actually it's even nicer this way, I think :)

Copy link
Copy Markdown
Collaborator

@AaronDJohnson AaronDJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AaronDJohnson AaronDJohnson merged commit 6f44ab0 into scikit-sparse:master Apr 16, 2024
@matospiso matospiso deleted the autofind-brew-installation branch April 16, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants