FIX Clip n_nonzero_coefs in OMP instead of raising#34193
Open
EdenRochmanSharabi wants to merge 1 commit into
Open
FIX Clip n_nonzero_coefs in OMP instead of raising#34193EdenRochmanSharabi wants to merge 1 commit into
EdenRochmanSharabi wants to merge 1 commit into
Conversation
OrthogonalMatchingPursuit raises a ValueError when n_nonzero_coefs > n_features, but LARS silently clips to n_features. This changes OMP to emit a UserWarning and clip, making the two algorithms consistent when used through DictionaryLearning(transform_algorithm="omp").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33454.
OrthogonalMatchingPursuitraises aValueErrorwhenn_nonzero_coefs > n_features, but LARS silently clips ton_features.This means
DictionaryLearning(transform_algorithm="omp")crashes whiletransform_algorithm="lars"works fine for the same input.This PR changes OMP to emit a
UserWarningand clipn_nonzero_coefsto
n_features, matching the LARS behavior. The change applies to bothorthogonal_mpandorthogonal_mp_gram.The clipping approach is consistent with how LARS handles this
internally (see
max_features = min(max_iter, n_features)in_lars_path_solver), where the cap was introduced as a memorypre-allocation guard rather than parameter validation.