DOC Improve ProgressBar rich dependency note with link and install command#34189
Open
EdenRochmanSharabi wants to merge 2 commits into
Open
DOC Improve ProgressBar rich dependency note with link and install command#34189EdenRochmanSharabi wants to merge 2 commits into
EdenRochmanSharabi wants to merge 2 commits into
Conversation
jeremiedbb
reviewed
Jun 3, 2026
Member
jeremiedbb
left a comment
There was a problem hiding this comment.
Thanks for the PR. Okay for the link, but we don't want to impose an install command. One can use conda for instance.
Comment on lines
+32
to
+33
| This callback requires `rich <https://rich.readthedocs.io>`_ to be installed. | ||
| It can be installed with ``pip install rich``. |
Member
There was a problem hiding this comment.
Suggested change
| This callback requires `rich <https://rich.readthedocs.io>`_ to be installed. | |
| It can be installed with ``pip install rich``. | |
| This callback requires `rich <https://rich.readthedocs.io>`_ to be installed. |
AnneBeyer
approved these changes
Jun 7, 2026
Contributor
AnneBeyer
left a comment
There was a problem hiding this comment.
Hi @EdenRochmanSharabi, thank you, LGTM.
A side note (on what I was suggesting in the old PR, just in case you didn't know this):
When you go to the Files changed tab at the top of a PR, you can also add your suggestions as a comment to specific lines of code. So you could have added this as a suggestion to the existing PR instead of opening a follow-up one (at least as long as it wasn't already merged).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow-up to #34168 (fixes #34166).
What does this implement/fix? Explain your changes.
Improves the
ProgressBardocstring note added in #34168 by:pip install richcommand so users know how to install itAny other comments?
Documentation-only change. As suggested in #34184, contributing the improvement here instead.