Conversation
|
Works for me. Is there a reason this is still in draft? |
The items in the TODO list, at least fix the logos and links. |
| - 0.5 :abbr:`FTE (Full-Time Equivalent)` or more | ||
| - less than 0.5 :abbr:`FTE (Full-Time Equivalent)` |
There was a problem hiding this comment.
where does 0.5 come from ? why not a threshold at 1 ?
There was a problem hiding this comment.
the idea is to match less significant contributions that typically do not cover salaries, but rather expenses.
| </a> | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Can you try adding an horizontal separator just above that to make it more visible when there's already something on the right side ?
There was a problem hiding this comment.
Thanks. Now it's weird when it's the only item in this section. But would probably be painful to add it conditionally on the existence of another item. So maybe not worth to add it in the first place. I let you decide
|
I like that the front page of scikit-learn.org focusses on the user, stuff that is relevant to people using scikit-learn is close to the top and easy to find. The listing of the sponsors/financial backers uses up a lot of vertical space and it isn't clear to me why the average user cares about this. What about something like the "Organizations That Use Dask" (but "Orgs that support scikit-learn") section from the dask website below the six tiles (Classification, Regression, ..)? We could give more vertical space to the section and maybe remove the "scikit-learn is made possible by the support of organizations and individuals committed to open source machine learning." title which I find a very long way to say "Organisations that support scikit-learn". I think it would look better if it was in the style of the dask page's "Orgs that use Dask". The current proposal looks somehow shoehorned in, with text in different colours, a bunch of logos, long sentences, and it isn't obvious enough to me (pretending I didn't already know who/what probabl is) that probabl is a place I can go to get enterprise support for scikit-learn. tl;dr: it is not clear to me what problem we are solving by having the logos so far up the front page and hence suggest placing it further down (where it could use more vertical space). Nit on the link text: how about "Learn more about scikit-learn’s financial support."? On the institutional support page (I think spinning it out from "About Us" is a good move): does INRIA still support the project financially? If not why not move it to the "Past sponsors" section? The sidebar changes are fine with me. It looks a bit untidy and if you aren't familiar with probabl you might think it is a generic advert for "blah something, advert, I have already stopped looking at it". |
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
We could move this into the panel that currently includes the "Who uses scikit-learn?" carousel, for instance above it. |
@GaelVaroquaux is still part-time at Inria. Maybe I should make that more explicit on the institutional support page? |
there's a discrepency between the active-financial-participation section that doesn't include inria and the home page banner that does. |
| :header-rows: 1 | ||
| :class: sk-funding-participation-table | ||
|
|
||
| * - 5 :abbr:`FTEs (Full-Time Equivalent)` or more |
| * |michelin| | ||
|
|
||
| * `The Chan-Zuckerberg Initiative <https://chanzuckerberg.com/>`_ and `Wellcome | ||
| Trust <https://wellcome.org/>`_ support the work of Lucy Liu, Dea Maria Leon |
|
As for the banner part, I think it'd make more sense to have it as a footer. Otherwise, fixing the dark mode stuff, and probably having the sidebar a bit looking nicer (?) I'm personally good with it. |
|
Alternatively, that banner can be repackaged and take the "who uses scikit-learn section" on the bottom. We can also update our quotes and all. |
|
I also find the banner on the top not in the right place. Having it before describing what scikit-learn does feels off. So I'm more in favor of what Tim proposes (#33704 (comment)), that is below the example and above the footer. Between above the footer and on the right side of the footer, I don't have a preference. |
|
Shall we try what @betatim proposes and that @jeremiedbb and @DeaMariaLeon seem to like? It will save @ogrisel redesign time while keeping the original idea to promote the block? |
|
I will update the PR to move the block to the location suggested by Tim and then see how to improve the rendering in dark mode. |
Fully agree @jeremiedbb. |
| :header-rows: 1 | ||
| :class: sk-funding-participation-table | ||
|
|
||
| * - 5 :abbr:`FTEs (Full-Time Equivalent)` or more |
There was a problem hiding this comment.
Are you sure it is 5 FTE only on scikit-learn? 5 people 100% all year round?
There was a problem hiding this comment.
The work done by @ogrisel , @snath-xoc , @antoinebaker , @StefanieSenger , @jeremiedbb, @lesteve , @glemaitre , and @cakedev0, myself, and some of @GaelVaroquaux 's time are all paid by Probabl. It's true that some are less active than others on the project due to other activities, but I think we can agree together it covers at least 5 FTE 😉







What:
Objectives:
I tried to update the list of financial supporters in part based on what I know and in part based on info provided by @ylechelle and @glemaitre. Let me know if you think that I missed things.
Still todo before final review:
and also but can be adjusted in a follow-up PR after review/merge: