Simplification revised#4
Merged
Merged
Conversation
…mer) This allows to define AbstractValues.toString() which will do by default just printing of all modified (non-default) values, and allows subclasses to override forEach() to include defaults which will be potentially useful for other purposes as well. Meaning, that ValuesToString is now just one possible BiConsumer.
This reduces boilerplate because derived classes don't have to define a constructor for the AbstractValues subclass.
Rename AbstractOptions.add() to setValue(). Rename AbstractValues.value() to getValueOrDefault().
Also add org.scijava.optional.examples.Playground that has the full implementation of the example given in the README and package javadoc.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporate some ideas from #2