Skip to content

Fix ignore step size #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ctrueden merged 2 commits into from
Dec 3, 2015
Merged

Fix ignore step size #209

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eca2a95
Fix bug of ignoring the step size of a parameter
Nov 25, 2015
fdf7494
Add test for step size of a command's parameter
Nov 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix bug of ignoring the step size of a parameter 
The step size attribute of a parameter is always ignored because there
is no converter that converts String to Number. The bug is fixed by
parsing the String to double. Similar bug exists in the script editor
and has been fixed.

See also:
c0ffe39
#205
  • Loading branch information
LeonYang5114 committed Nov 25, 2015
commit eca2a95b3f6de1c22aaafecb324c39346334ce9f
9 changes: 8 additions & 1 deletion src/main/java/org/scijava/command/CommandModuleItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,14 @@ public T getMaximumValue() {

@Override
public Number getStepSize() {
return tValue(getParameter().stepSize(), Number.class);
final String value = getParameter().stepSize();
try {
final double stepSize = Double.parseDouble(value);
return stepSize;
}
catch (final NumberFormatException exc) {
return tValue(value, Number.class);
}
}

@Override
Expand Down