Add the user-interface independent part of a generic script interpreter#127
Merged
Conversation
Contributor
Author
|
There is an open problem with this PR, still: command histories are not persisted correctly. To test this, start the |
Member
|
Also, it looks like before this can be merged, the changes to |
Contributor
Author
Once the test ran successfully, bar is distinctively different from 0... Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The most generic way to provide a bunch of Strings to persist is by passing an Iterable<String> for writing and handling an Iterable<String> when reading. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Contributor
Author
The problem was actually in the |
This is similar to the LinkedHashMap structure, except that an already-existing item can be easily put to the front of the list, or the back. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The newly-introduced History class maintains the history of most recently executed statements and has functionality to persist and retrieve the list from the preferences. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The newly-introduced ScriptInterpreter class provides all the functionality of a script interpreter sans the graphical user interface. It can execute statements and persists a history of most recently executed statements. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
It simplifies things downstream to be able to query the associated ScriptLanguage later, since it is known at construction time anyway. This does *not* persist the most recently used interpreter language!
The 'current command' is the command that is not yet in the history. It is very convenient to be able to go back in history, just to have a look, before continuing to craft the current command (and it would be annoying if it was lost when going back in history). Of course, if the user decides to execute a different command from the history instead, the edits to the 'current command' are lost. This behavior is most in line with the Unix shell behavior power users might be used to. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
that referenced
this pull request
Oct 15, 2014
Add the user-interface independent part of a generic script interpreter
Member
|
yay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fiji introduced interpreters for the script languages it supported. When ImageJ2 overhauled the idea of Fiji's scripting framework, reimplementing it cleanly on top of the SciJava common framework, the interpreters were dropped due to a misconception how widely in use they are. For example, Pavel Tomancak – the father of Fiji – pointed out that he uses the interpreter quite heavily.
Therefore, let's introduce a clean rewrite of the script interpreters. This topic branch adds the backend that is not visible to users; a corresponding Pull Request will be opened in the
imagej-ui-swingproject in a moment.