Skip to content

Create Pref Service #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hinerm merged 16 commits into from
Jul 25, 2014
Merged

Create Pref Service #102

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9f210a7
Refactor Prefs to PrefService
hinerm Jul 18, 2014
4ef6f00
Update Prefs usage to PrefService
hinerm Jul 21, 2014
992f0b8
ModuleService: add save/load item methods
hinerm Jul 21, 2014
cc97d1b
Mark saveValue and loadValue deprecated
hinerm Jul 21, 2014
d503e31
Refactor for ModuleService saving and loading
hinerm Jul 21, 2014
ce0f105
AbstractPrefService: account for priority
hinerm Jul 21, 2014
9050328
Clean up code
hinerm Jul 21, 2014
6fe0553
DefaultPrefService: add TODO
hinerm Jul 21, 2014
f857d0f
Deprecate Prefs
hinerm Jul 21, 2014
a9a109c
PrefService: remove setStaticBehavior method
hinerm Jul 24, 2014
9abe3d9
PrefService: remove Preferences imports
hinerm Jul 24, 2014
7ff590f
Rename preferences to prefs package
hinerm Jul 25, 2014
344d6bc
DefaultPrefService: fix javadoc
ctrueden Jul 25, 2014
963d4eb
DefaultPrefService: do not reference Prefs class
ctrueden Jul 25, 2014
cdeb735
Add down-the-middle unit tests for PrefService
ctrueden Jul 25, 2014
a0c6c95
AbstractPrefService: suppress warnings
hinerm Jul 25, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
AbstractPrefService: account for priority 
It was discovered that the initialize method of multiple PrefService
impls was being invoked - leading to the LOWEST priority overwriting the
static service field in the Prefs utility class (since it was the last
initialize method to execute).

Added a check for priority so that lower priority services don't
overwrite higher.
  • Loading branch information
@hinerm
hinerm committed Jul 25, 2014
commit ce0f105114e9ca73a3de9e8bfcee70735093f2d6
2 changes: 1 addition & 1 deletion src/main/java/org/scijava/preferences/AbstractPrefService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public void initialize() {

@Override
public void setStaticBehavior() {
Prefs.setDelegateService(this);
Prefs.setDelegateService(this, getPriority());
}

}
11 changes: 9 additions & 2 deletions src/main/java/org/scijava/util/Prefs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ public final class Prefs {

private static PrefService prefServiceNoContext;

private static double servicePriority = Double.MIN_VALUE;

private Prefs() {
// prevent instantiation of utility class
}
Expand Down Expand Up @@ -295,8 +297,13 @@ public static List<String> getList(final Preferences preferences) {
/**
* Sets the {@link PrefService}
*/
public static void setDelegateService(final PrefService prefService) {
Prefs.prefService = prefService;
public static void setDelegateService(final PrefService prefService,
final double priority)
{
if (Double.compare(priority, Prefs.servicePriority) > 0) {
Prefs.prefService = prefService;
Prefs.servicePriority = priority;
}
}

// -- Helper methods --
Expand Down