Improve the multi-module build for more flexible versioning#234
Merged
Conversation
b12b9d2 to
266672b
Compare
gselzer
reviewed
Jun 3, 2024
d7bc322 to
e8bc616
Compare
Co-authored-by: Gabriel Selzer <gjselzer@wisc.edu>
It is important that the license blurbs stay exactly how the license-maven-plugin generates them. No fighting auto-formatters!
And regenerate the autogenerated source files. It is important that they remain exactly the same as: bin/generate.groovy && mvn license:update-file-header Otherwise, it is too burdensome to use the code generation tooling as intended whenever changes are needed to the templates. No fighting autoformatters! This commit makes the following changes: * Remove obsolete .arityX() calls from Velocity templates. * Align formatting of all "do not edit" warning blurbs.
And make the toplevel POM into solely an aggregator.
A BiFunction would take three type parameters, not two.
I.e.: deploy only components intended to be consumed as dependencies.
* parse.ops -> scijava.ops.parse * op.version -> scijava.ops.op-version All scijava-related system properties start with `scijava.`. All scijava-ops-related properties should start with `scijava.ops.`.
It's not a hack, exactly. Individually opening every one of the 105 org.scijava.ops.image.** packages is very verbose, and also does not fully work on its own to let all tests pass. Maybe there are also scijava.surefire.args flags that need to be set? But rather than mess with that, we stick with the solution that works via a single keyword.
228521e to
bad456d
Compare
bad456d to
e1b3633
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patchset reworks the modules to each extend pom-scijava directly, and use a toplevel aggregator POM that is not a parent. It avoids deploying the parent, as well as a few non-library components not intended for downstream consumption. It also includes miscellaneous fixes done in preparation for release.