n5, imglib2, multiview-reconstruction bumps#306
Draft
bogovicj wants to merge 8 commits into
Draft
Conversation
* skipping tests for which prereqs not met
Member
Member
|
@bogovicj Still waiting for the n5-universe smelt to finish, but already I've seen how the tests are behaving now: n5-universe test logThe TL;DR is that even with the new test skipping logic, some of the tests take an extremely long time to finish. Here are they ones >10s, sorted by time taken: So the timeouts must be happening before the test-skipping decision is made... For now, I will configure pombast to skip the above problematic tests. If you later improve things further, we can re-enable any adjusted tests then. |
Contributor
Author
|
@ctrueden , thanks for trying it out and the update |
* used by n5-aws-s3
ctrueden
reviewed
Jun 22, 2026
|
|
||
| <!-- Amazon S3 - https://aws.amazon.com/sdkforjava --> | ||
| <aws.version>1.12.791</aws.version> | ||
| <aws.version>2.30.10</aws.version> |
Member
There was a problem hiding this comment.
@bogovicj The groupId changed from com.amazon to software.amazon.awssdk, and artifactId from aws-java-sdk-core and aws-java-sdk-s3 to simply s3, so this version bump does not work as written. I am changing it on the pombast branch, so don't worry about it.
Member
There was a problem hiding this comment.
It looks like Amazon advises consumers to import the AWS SDK BOM, so I am going to do that in pom-scijava.
Member
There was a problem hiding this comment.
@bogovicj Is there some specific reason why 2.30.10 and not 2.46.15 (newest release as of this writing)?
Contributor
Author
There was a problem hiding this comment.
nope, I'll try the latest locally. thanks @ctrueden
Member
There was a problem hiding this comment.
Thanks for testing the latest, @bogovicj. Note that after importing the AWS SDK BOM, the pom-scijava managed component count goes from 657 to 1103 (446 AWS components!) 😱 I'll take steps to suppress those from the https://status.scijava.org/ view because it's a bit overwhelming otherwise.
Contributor
Author
There was a problem hiding this comment.
2.46.15 looks good for n5-aws-s3. I'll bump the version
* newest release at this time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still waiting on JaneliaSciComp/multiview-reconstruction#98
But update n5 artifacts with tests that fail during smelt (due to unmet prerequisites), these tests are now skipped.