Skip to content

Bump n5 artifact versions#245

Closed
bogovicj wants to merge 9 commits into
scijava:masterfrom
bogovicj:n5-2023Aug
Closed

Bump n5 artifact versions#245
bogovicj wants to merge 9 commits into
scijava:masterfrom
bogovicj:n5-2023Aug

Conversation

@bogovicj

@bogovicj bogovicj commented Aug 4, 2023

Copy link
Copy Markdown
Contributor

This commit updates the versions of many n5 artifacts, many of them major version bumps.
It also adds a new artifact: n5-universe, and updates the versions of some packages depending
on n5: bigdataviewer-core, and bigwarp

@ctrueden I'm not sure how pom-scijava semver updates go, but I bumped the major version
in its own commit. Please revert / change if that wasn't the right thing to do.

bogovicj added 3 commits August 3, 2023 17:01
@bogovicj
Bump n5 to 3.0.0
f228d6c 
* bump all other n5 artifact versions
* add n5-universe
* update n5 dependencies: bigwarp, bigdataviewer
@bogovicj
bump version to 37.0.0-SNAPSHOT
fd88d10
@bogovicj @ctrueden
Bump n5 to 3.0.0
f8b8761 
* bump all other n5 artifact versions
* add n5-universe
* update n5 dependencies: bigwarp
@ctrueden

ctrueden commented Aug 4, 2023

Copy link
Copy Markdown
Member

@bogovicj Thanks a lot. I took the liberty of rebasing this over the latest mainline branch.

It looks like there are two downstream components still in need of updating in conjunction with this effort:

multiview-reconstruction

ExportN5API.java:[176,25] exception java.io.IOException is never thrown in body of corresponding try statement

n5-blosc

BloscCompressionTest.java:[50,8] org.janelia.saalfeldlab.n5.blosc.BloscCompressionTest is not abstract and does not override abstract method createN5Reader(java.lang.String,com.google.gson.GsonBuilder) in org.janelia.saalfeldlab.n5.AbstractN5Test
BloscCompressionTest.java:[75,25] cannot find symbol
  symbol:   variable n5
  location: class org.janelia.saalfeldlab.n5.blosc.BloscCompressionTest

@bogovicj

bogovicj commented Aug 4, 2023

Copy link
Copy Markdown
Contributor Author

Thanks, I'm on it

@bogovicj

bogovicj commented Aug 4, 2023

Copy link
Copy Markdown
Contributor Author

@StephanPreibisch
I bumped multiview-reconstruction to the latest version (3.2.3). Is that correct / alright with you?

@ctrueden ctrueden mentioned this pull request Aug 16, 2023
Closed
@ctrueden

ctrueden commented Aug 16, 2023

Copy link
Copy Markdown
Member

Thanks to @skalarproduktraum, who got the ball rolling, there are now new versions of ui-behaviour and bigdataviewer-core that depend on snakeyaml 2.0; see #246. But because bigdataviewer-core already updated to n5 3.0.0, we cannot merge #246 until this PR is completed first. @bogovicj What's the current status of this work?

@bogovicj

bogovicj commented Sep 1, 2023

Copy link
Copy Markdown
Contributor Author

This is ready as far as I'm concerned. The build is still failing because of org.scijava.text.TextServiceTest.testGetHandler:

Error:  Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.002 s <<< FAILURE! -- in org.scijava.text.TextServiceTest
Error:  org.scijava.text.TextServiceTest.testGetHandler -- Time elapsed: 0 s <<< FAILURE!

but I'm not sure how to address it.

@StephanPreibisch

StephanPreibisch commented Sep 1, 2023

Copy link
Copy Markdown
Member

Hi, in that on the main Fiji update site? If so, we should add BigStitcher and change Image Stitching & Descriptor-based registration and others ...

ctrueden added a commit that referenced this pull request Sep 27, 2023
@ctrueden
Merge pull request #245 from bogovicj/n5-2023Aug
9173c87 
Bump n5 artifact versions
@ctrueden

ctrueden commented Sep 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

A rebased version of this PR was merged as 9173c87. Thanks again @bogovicj for all your efforts on this!

@ctrueden ctrueden closed this Sep 27, 2023
@bogovicj

bogovicj commented Sep 28, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @ctrueden !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bogovicj @ctrueden @StephanPreibisch