Add RestrictedDiet enums to match GS1 DietTypeCode, add example #4666#4682
Add RestrictedDiet enums to match GS1 DietTypeCode, add example #4666#4682alex-jansen wants to merge 1 commit intomainfrom
Conversation
|
Hey, I made a complete list of what's already present and what not. @alex-jansen what do you think? OK = already present
|
|
@fthobe I got the impression from this comment that we only wanted to add the few missing ones that are defined by GS1 and not add a large set of others, since there are so many different diets? Others (such as FODMAP illustrated in my example) can be added using the Diet type. |
|
Update This is the complete list is Sweden covering all available 34 codes (updated in 2025): https://gs1.se/en/guides/documentation/code-lists/t4066-diet-type-code/
All countries now share the same list. Another example is Germany: https://gdsn.gs1-germany.de/codeList?id=DietTypeCode (also updated last time 2025) I would consider to support this also for products to cover (convenience) food. |
|
@philarcher there seems to be a rather short list on DietTypeCode on gs1.org while there are more extensive lists on literally every country I looked on updated recently like in Sweden and Germany. I believe the gs1.org codes have not been updated or are maybe incomplete. Is there any matrix of which values apply to which countries if they differ by country? |
|
This discussion provides more support for the original suggestion to add DefinedTerm to the range of suitableForDiet. That way any external defined enumeration or code list can be referenced. That would be better than just copying over enum values, which change over time. Example: |
|
Fine, I do believe that this has some great potential regarding shopping and recipes but I can see resistance is strong here. I'd implement the gs1 list also because it proofed to be immensely stable (two changes in 10 years) and retailers do have the data and I feel adoption with an external vocabulary was always lower given the implications of having to either hardcode them into templates or having to add DB schemas in a manor that is more invasive as most eCommerce systems have custom attributes (also filterable), but those usually do not support external links (more like a "Color" : "Red" or "Diet" : "Keto" than a fully fledged json array in the backend). Having worked a lot in the past on structured data on the data providing side, I feel this makes a relatively limited problem a large implementation effort on content side. |
|
Sure @fthobe please send a PR with the missing enums and happy to merge them in since ultimately it is not a major risk or breaking change. |
|
Thanks :) How should I handle the fact that they seem universally available across all EU countries, but not present on gs1.org? E.g. |
|
Hang on, we (GS1) might be able to help :-) I'll get someone on to this thread who can. |
My hero without cape ;) |
|
@philarcher can you push all 34 values supported into v3.1.35? It seems like all values are unique. |
|
@fthobe @alex-jansen I am a direct colleague of Phil and will support him on GS1-related topics in discussions like this where possible. |
|
@alex-jansen how about we merge this and keep the discussion in the issue #4666? I can always add the remaining items from gs1 later. |
No description provided.