Conversation
File at https://schema.org/docs/jsonldcontext.jsonld misses all "DateTime" types for every property, mostly due a mispelled case in the building script.
|
Fails in the build test. |
…teModified property
|
Seems that the test itself was broken: documentation says that |
|
tests now breaks for auditDate |
gmackenz
left a comment
There was a problem hiding this comment.
Test has another breakage for "auditDate"
|
Ok, I totally failed to properly check my pull request... Sorry... But now, I'm a bit confused. JSON-LD specification says something about expressing a On the other hand, given my limited understanding of Ruby, seems that I've tried replacing |
|
Not sure what value the test_basics for "Date" has and if we should keep it. |
|
Anyone else have some background on test or what should be done? |
|
This pull request is being nudged due to inactivity. |
|
Based on my read, the @type in JSON-LD context is a data/value type (or it would be type @id), so it's like the type of a typed literal in RDF. So it really can't have multiple values in that definition. It's not like a node type where JSON-LD allows multiple values. So I don't really understand what you would put here if it could be either data type. In Google's internal context file, we don't generate these types at all. So I guess I would rather we just get rid of the declaration in that case. Maybe someone with more background can take a stab here though. |
File at https://schema.org/docs/jsonldcontext.jsonld misses all "DateTime" types for every property, mostly due a mispelled case in the building script.