Fix off-by-one in ioctl_EVIOCG_bits

frederikaalund · frederikaalund · commit 9871fad77e89 · 2020-08-12T16:55:42.000+02:00
This bug caused values at the end of the list to not be reported back.

Example: On my system, SW_PEN_INSERTED (0x0f) is the last switch constant. That is,
SW_MAX=SW_PEN_INSERTED. Other tools (python-libevdev) correctly reported this switch
as 'set' but python-evdev did not. This commit fixes this issue.
diff --git a/evdev/input.c b/evdev/input.c
@@ -413,7 +413,7 @@ ioctl_EVIOCG_bits(PyObject *self, PyObject *args)
         return NULL;
 
     PyObject* res = PyList_New(0);
-    for (int i=0; i<max; i++) {
+    for (int i=0; i<=max; i++) {
         if (test_bit(bytes, i)) {
             PyList_Append(res, Py_BuildValue("i", i));
         }

Original file line number	Diff line number	Diff line change
`@@ -413,7 +413,7 @@ ioctl_EVIOCG_bits(PyObject self, PyObject args)`
`413`	`413`	`return NULL;`
`414`	`414`
`415`	`415`	`PyObject* res = PyList_New(0);`
`416`		`- for (int i=0; i<max; i++) {`
	`416`	`+ for (int i=0; i<=max; i++) {`
`417`	`417`	`if (test_bit(bytes, i)) {`
`418`	`418`	`PyList_Append(res, Py_BuildValue("i", i));`
`419`	`419`	`}`