Call the callback one last time.#51
Merged
Merged
Conversation
The status is updated way after the event handler is called, also any output remaining on the queue will be processed without calling the callback. This prevents such
conditions which amongst other things allows to have callbacks like this:
def mycallback(nm):
if (nm.has_terminated()):
print ("Done!")
Owner
|
could you please rebase and reissue your pull request? thanks! |
Contributor
Author
|
Strange, this branch is based against the last one on github so there are no changes to rebase on. Did you push any changes you want me to rebase on? $ git fetch gupstream |
savon-noir
added a commit
that referenced
this pull request
Mar 3, 2015
Call the callback one last time.
Owner
|
ok, looks good. Thanks for your contribution, pull reqs are always welcome :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status is updated way after the event handler is called, also any output remaining on the queue will be processed without calling the callback. This prevents such
conditions which amongst other things allows to have callbacks like this:
def mycallback(nm):
if (nm.has_terminated()):
print ("Done!")