DWC Business Builder#6990
Merged
MichaelCzcz merged 12 commits intosap-tutorials:masterfrom Sep 23, 2021
Merged
Conversation
…les', 'data-warehouse-cloud-datapreparation-2-monitor', 'data-warehouse-cloud-datapreparation-3-replication', 'data-warehouse-cloud-datapreparation-4-views' from QA to Production
…w', 'data-warehouse-cloud-businessbuilder2-dataset', 'data-warehouse-cloud-businessbuilder3-dimension', 'data-warehouse-cloud-businessbuilder4-factmodel', 'data-warehouse-cloud-businessbuilder5-consumption', 'data-warehouse-cloud-businessbuilder6-auth', 'data-warehouse-cloud-businessbuilder7-repo' from QA to Production
Collaborator
|
@cheg7 There are no files in your PR. What did you change? |
…w', 'data-warehouse-cloud-businessbuilder2-dataset', 'data-warehouse-cloud-businessbuilder3-dimension', 'data-warehouse-cloud-businessbuilder4-factmodel', 'data-warehouse-cloud-businessbuilder5-consumption', 'data-warehouse-cloud-businessbuilder6-auth', 'data-warehouse-cloud-businessbuilder7-repo' from QA to Production
Contributor
Author
Hi @MichaelCzcz , I had added metadata to the tutorials as suggested by Daniel. It seems like we need actual changes in the file to be able to compare the changes. I now have modified something in each file and have 7 changes. Request you to merge it to production. Thank you! |
MichaelCzcz
requested changes
Sep 23, 2021
| <iframe width="560" height="315" src="https://www.youtube.com/embed/LNT7ciCJnpA" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe> | ||
|
|
||
| In this tutorial, we will use an example dataset that contains information about sales. Please keep in mind that any data that will be used in the Business Builder needs to first be connected to or imported into SAP Data Warehouse Cloud before you can start creating business objects with the Business Builder. | ||
| In this tutorial, we will use an example dataset that contains information about sales. Please keep in mind that any data that will be used in the Business Builder needs to first be connected to or imported into SAP Data Warehouse Cloud before you can start creating business objects with Business Builder. |
Collaborator
There was a problem hiding this comment.
Please don't use the "royal we", say "you will use" instead.
|
|
||
|
|
||
| In this tutorial, we will use an example dataset that contains information about sales. Please keep in mind that any data that will be used in the Business Builder needs to first be connected to or imported into SAP Data Warehouse Cloud before you can start creating business objects with the Business Builder. | ||
| In this tutorial, we will use an example dataset that contains information about sales. Please keep in mind that any data that will be used in the Business Builder needs to first be connected to or imported into SAP Data Warehouse Cloud before you can start creating business objects with Business Builder. |
Collaborator
There was a problem hiding this comment.
Please don't use the "royal we", say "you will use" instead.
Contributor
Author
There was a problem hiding this comment.
Changes suggested have been made to the tutorials. Thank you!
…w', 'data-warehouse-cloud-businessbuilder2-dataset', 'data-warehouse-cloud-businessbuilder3-dimension', 'data-warehouse-cloud-businessbuilder4-factmodel', 'data-warehouse-cloud-businessbuilder5-consumption', 'data-warehouse-cloud-businessbuilder6-auth', 'data-warehouse-cloud-businessbuilder7-repo' from QA to Production
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.