Skip to content

DWC Business Builder#6990

Merged
MichaelCzcz merged 12 commits intosap-tutorials:masterfrom
cheg7:master
Sep 23, 2021
Merged

DWC Business Builder#6990
MichaelCzcz merged 12 commits intosap-tutorials:masterfrom
cheg7:master

Conversation

@cheg7
Copy link
Copy Markdown
Contributor

@cheg7 cheg7 commented Sep 21, 2021

No description provided.

cheg7 added 8 commits August 25, 2021 11:37
…les', 'data-warehouse-cloud-datapreparation-2-monitor', 'data-warehouse-cloud-datapreparation-3-replication', 'data-warehouse-cloud-datapreparation-4-views' from QA to Production
…w', 'data-warehouse-cloud-businessbuilder2-dataset', 'data-warehouse-cloud-businessbuilder3-dimension', 'data-warehouse-cloud-businessbuilder4-factmodel', 'data-warehouse-cloud-businessbuilder5-consumption', 'data-warehouse-cloud-businessbuilder6-auth', 'data-warehouse-cloud-businessbuilder7-repo' from QA to Production
@MichaelCzcz
Copy link
Copy Markdown
Collaborator

@cheg7 There are no files in your PR. What did you change?

…w', 'data-warehouse-cloud-businessbuilder2-dataset', 'data-warehouse-cloud-businessbuilder3-dimension', 'data-warehouse-cloud-businessbuilder4-factmodel', 'data-warehouse-cloud-businessbuilder5-consumption', 'data-warehouse-cloud-businessbuilder6-auth', 'data-warehouse-cloud-businessbuilder7-repo' from QA to Production
@cheg7 cheg7 requested a review from thecodester as a code owner September 22, 2021 21:49
@cheg7
Copy link
Copy Markdown
Contributor Author

cheg7 commented Sep 22, 2021

@cheg7 There are no files in your PR. What did you change?

Hi @MichaelCzcz , I had added metadata to the tutorials as suggested by Daniel. It seems like we need actual changes in the file to be able to compare the changes. I now have modified something in each file and have 7 changes. Request you to merge it to production.

Thank you!

<iframe width="560" height="315" src="https://www.youtube.com/embed/LNT7ciCJnpA" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>

In this tutorial, we will use an example dataset that contains information about sales. Please keep in mind that any data that will be used in the Business Builder needs to first be connected to or imported into SAP Data Warehouse Cloud before you can start creating business objects with the Business Builder.
In this tutorial, we will use an example dataset that contains information about sales. Please keep in mind that any data that will be used in the Business Builder needs to first be connected to or imported into SAP Data Warehouse Cloud before you can start creating business objects with Business Builder.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use the "royal we", say "you will use" instead.



In this tutorial, we will use an example dataset that contains information about sales. Please keep in mind that any data that will be used in the Business Builder needs to first be connected to or imported into SAP Data Warehouse Cloud before you can start creating business objects with the Business Builder.
In this tutorial, we will use an example dataset that contains information about sales. Please keep in mind that any data that will be used in the Business Builder needs to first be connected to or imported into SAP Data Warehouse Cloud before you can start creating business objects with Business Builder.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use the "royal we", say "you will use" instead.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes suggested have been made to the tutorials. Thank you!

…w', 'data-warehouse-cloud-businessbuilder2-dataset', 'data-warehouse-cloud-businessbuilder3-dimension', 'data-warehouse-cloud-businessbuilder4-factmodel', 'data-warehouse-cloud-businessbuilder5-consumption', 'data-warehouse-cloud-businessbuilder6-auth', 'data-warehouse-cloud-businessbuilder7-repo' from QA to Production
@MichaelCzcz MichaelCzcz merged commit 7d20972 into sap-tutorials:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants