Skip to content

AICORE Evaluation Tutorials#24121

Merged
rbrainey merged 3 commits intosap-tutorials:masterfrom
I321506:evaluation_tutorials
Apr 1, 2026
Merged

AICORE Evaluation Tutorials#24121
rbrainey merged 3 commits intosap-tutorials:masterfrom
I321506:evaluation_tutorials

Conversation

@I321506
Copy link
Copy Markdown
Contributor

@I321506 I321506 commented Apr 1, 2026

No description provided.

@I321506 I321506 requested a review from rbrainey April 1, 2026 14:22
@I321506
Copy link
Copy Markdown
Contributor Author

I321506 commented Apr 1, 2026

@rbrainey Please review and merge this PR. Thanks

rbrainey
rbrainey requested changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@rbrainey rbrainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you happy with the redaction in the URL for 22b7d22#diff-e93d67285c4488a0dc6e88cf891d9064a341317e58e79bce1b12e5b10cbe145d -- it feels like someone trying hard enough could extract the URL. Does it matter, though?

@I321506 I321506 requested a review from rbrainey April 1, 2026 14:54
@I321506
Copy link
Copy Markdown
Contributor Author

I321506 commented Apr 1, 2026 •
edited
Loading

Are you happy with the redaction in the URL for 22b7d22#diff-e93d67285c4488a0dc6e88cf891d9064a341317e58e79bce1b12e5b10cbe145d -- it feels like someone trying hard enough could extract the URL. Does it matter, though?

@rbrainey This link is not an exact url as some of the placeholders needs to replace with actual value which is some internally by the application and it requires credentials to access. Also after the test we usually delete the data. So shouldn't be an issue.

@rbrainey rbrainey merged commit 547e879 into sap-tutorials:master Apr 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbrainey rbrainey Awaiting requested review from rbrainey

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@I321506 @rbrainey