Skip to content

Fix issue: #18555 and #18556 #18595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelCzcz merged 5 commits into from
Jul 7, 2022
Merged

Fix issue: #18555 and #18556 #18595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d7fb3a
fix spelling
TiaXu1122 Apr 28, 2022
9417894
fix validator
TiaXu1122 Apr 28, 2022
cd415d6
Merge branch 'sap-tutorials:master' into master
TiaXu1122 Jul 7, 2022
6b6beb8
fix issue: https://github.com/sap-tutorials/Tutorials/issues/18555
TiaXu1122 Jul 7, 2022
137c079
fix issue: https://github.com/sap-tutorials/Tutorials/issues/18556
TiaXu1122 Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tutorials/basic-nodejs-application-create/basic-nodejs-application-create.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ Where:
- `PATH` is a path on the server.
- `HANDLER` is the function executed when the route is matched.

Add basic logic into the default get endpoint with the following code snippets:
Add basic logic into the default get endpoint. To make the necessary changes you should navigate to `kyma-multitenant-node/routes/index.js` and add the logic with the following code snippets:

```javascript
/**
Expand Down
6 changes: 1 addition & 5 deletions tutorials/deploy-nodejs-application-kyma/deploy-nodejs-application-kyma.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,7 @@ For example:
[ACCORDION-END]

[ACCORDION-BEGIN [Step 2: ](Determine Kyma Cluster Domain)]
In your Kyma dashboard, find the full Kyma cluster domain in the downloaded `kubeconfig.yml` file or in the URL of the Kyma dashboard.

For example:

![image-20211214133533870](image-20211214133533870.png)
Find the full Kyma cluster domain in the downloaded `kubeconfig.yml` file. For example: `e6803e4.kyma.shoot.live.k8s-hana.ondemand.com`.


[DONE]
Expand Down