Skip to content

Commit 8d2c441

Browse files
committed
deps: V8: cherry-pick 931bdbd76f5b
Original commit message: [torque] fix build on VS2017 Node.js build fails on VS2017 without these headers, see the downstream issue (nodejs/node-v8#128). Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl> Co-authored-by: gengjiawen <technicalcute@gmail.com> Change-Id: I771eab435dce5cf548581f3acd78681180c77692 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2093951 Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#66661} Refs: v8/v8@931bdbd PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 049160d commit 8d2c441

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
# Reset this number to 0 on major V8 upgrades.
3737
# Increment by one for each non-official patch applied to deps/v8.
38-
'v8_embedder_string': '-node.8',
38+
'v8_embedder_string': '-node.9',
3939

4040
##### V8 defaults for Node.js #####
4141

deps/v8/src/torque/implementation-visitor.cc

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3964,6 +3964,26 @@ void ImplementationVisitor::GenerateExportedMacrosAssembler(
39643964
h_contents << "#include \"torque-generated/csa-types-tq.h\"\n";
39653965
h_contents
39663966
<< "#include \"torque-generated/internal-class-definitions-tq.h\"\n";
3967+
cc_contents << "#include \"src/objects/free-space.h\"\n";
3968+
cc_contents << "#include \"src/objects/js-regexp-string-iterator.h\"\n";
3969+
cc_contents << "#include \"src/objects/ordered-hash-table.h\"\n";
3970+
cc_contents << "#include \"src/objects/property-descriptor-object.h\"\n";
3971+
cc_contents << "#include \"src/objects/synthetic-module.h\"\n";
3972+
cc_contents << "#include \"src/objects/template-objects.h\"\n";
3973+
{
3974+
IfDefScope intl_scope(cc_contents, "V8_INTL_SUPPORT");
3975+
cc_contents << "#include \"src/objects/js-break-iterator.h\"\n";
3976+
cc_contents << "#include \"src/objects/js-collator.h\"\n";
3977+
cc_contents << "#include \"src/objects/js-date-time-format.h\"\n";
3978+
cc_contents << "#include \"src/objects/js-display-names.h\"\n";
3979+
cc_contents << "#include \"src/objects/js-list-format.h\"\n";
3980+
cc_contents << "#include \"src/objects/js-locale.h\"\n";
3981+
cc_contents << "#include \"src/objects/js-number-format.h\"\n";
3982+
cc_contents << "#include \"src/objects/js-plural-rules.h\"\n";
3983+
cc_contents << "#include \"src/objects/js-relative-time-format.h\"\n";
3984+
cc_contents << "#include \"src/objects/js-segment-iterator.h\"\n";
3985+
cc_contents << "#include \"src/objects/js-segmenter.h\"\n";
3986+
}
39673987
cc_contents << "#include \"torque-generated/" << file_name << ".h\"\n";
39683988

39693989
for (SourceId file : SourceFileMap::AllSources()) {

0 commit comments

Comments
 (0)