Skip to content

Commit 049160d

Browse files
committed
deps: V8: cherry-pick 1e36e21acc40
Original commit message: Remove unnecessary export, which happens to break MSVC DLL builds. Change-Id: I47c9211274cefd26bde6bd93aa7503e022df4357 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2042874 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Bill Ticehurst <billti@microsoft.com> Cr-Commit-Position: refs/heads/master@{#66179} Refs: v8/v8@1e36e21 PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 0220c29 commit 049160d

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
# Reset this number to 0 on major V8 upgrades.
3737
# Increment by one for each non-official patch applied to deps/v8.
38-
'v8_embedder_string': '-node.7',
38+
'v8_embedder_string': '-node.8',
3939

4040
##### V8 defaults for Node.js #####
4141

deps/v8/src/heap/memory-measurement.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ namespace internal {
1919
class Heap;
2020
class NativeContextStats;
2121

22-
class V8_EXPORT_PRIVATE MemoryMeasurement {
22+
class MemoryMeasurement {
2323
public:
2424
explicit MemoryMeasurement(Isolate* isolate);
2525

0 commit comments

Comments
 (0)