Repository navigation
Fix #30971: Handle requisites correctly for empty SLS files - #68534
Merged
Merged
Conversation
bdrx312
reviewed
Dec 15, 2025
Contributor
|
Changelog |
bdrx312
reviewed
Dec 17, 2025
twangboy
force-pushed
the
issue/30971/3006.x
branch
from
January 15, 2026 21:46
00f5685 to
28e8967
Compare
Empty SLS files were not being tracked properly for requisite checking, causing 'requisite not found' errors. This fix ensures empty SLS files are processed and tracked correctly for requisite dependencies. - Added _processed_sls_files set to track processed SLS files - Track SLS files in compile_high_data even if they produce no chunks - Check _processed_sls_files when validating SLS requisites - Handle empty SLS requisites in call_chunk execution - Track SLS files in render_state and get_highstate - Added test case to test_require.py to verify the fix
- Keep import from salt.utils.datastructures (odict is deprecated) - Restore str-to-list conversion for check_cmd that was inadvertently removed - Remove unused local processed_sls_files in compile_high_data; track on self._processed_sls_files instead - Replace the duplicated empty-SLS handling in call_chunk with a single post-loop check in check_requisite and the lost-requisite builder - Drop redundant tracking in render_highstate and include processing; the render_state path already records the SLS in _processed_sls_files - Add changelog entry
twangboy
approved these changes
Jun 15, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty SLS files were not being tracked properly for requisite checking, causing 'requisite not found' errors. This fix ensures empty SLS files are processed and tracked correctly for requisite dependencies.
Fixes #30971