Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

fix(build): update nx to 9.4.0#447

Merged
NetanelBasal merged 2 commits intosalesforce:masterfrom
xbaun:fix-babel-preset-env
Jun 15, 2020
Merged

fix(build): update nx to 9.4.0#447
NetanelBasal merged 2 commits intosalesforce:masterfrom
xbaun:fix-babel-preset-env

Conversation

@xbaun
Copy link
Copy Markdown
Contributor

@xbaun xbaun commented Jun 14, 2020 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the new behavior?

Update nx to 9.4.0 to fix nodejs/node#32852 when building akita with node v12/v13.

Does this PR introduce a breaking change?

  • Yes
  • No

@NetanelBasal NetanelBasal merged commit e75ef62 into salesforce:master Jun 15, 2020
@NetanelBasal
Copy link
Copy Markdown
Collaborator

NetanelBasal commented Jun 15, 2020

https://github.com/datorama/akita/runs/771327457?check_suite_focus=true

@xbaun
Copy link
Copy Markdown
Contributor Author

xbaun commented Jun 15, 2020 •
edited
Loading

Probably the problem is that node_modules is cached: https://github.com/datorama/akita/runs/771322765?check_suite_focus=true#step:4:8

@NetanelBasal
Copy link
Copy Markdown
Collaborator

NetanelBasal commented Jun 15, 2020

But it should invalidate it when yarn.lock changes.

@xbaun
Copy link
Copy Markdown
Contributor Author

xbaun commented Jun 15, 2020 •
edited
Loading

It's just a guess by me, because the build action ran on my branch without any errors and nx is using the node_modules/.cache folder for caching build targets. In the action log it looks like the cache is not invalidated.

@NetanelBasal
Copy link
Copy Markdown
Collaborator

NetanelBasal commented Jun 15, 2020

Let's remove the cache and see if it works.

@NetanelBasal
Copy link
Copy Markdown
Collaborator

NetanelBasal commented Jun 15, 2020

Released.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Errors from conditional exports after upgraded to Node 13.13

2 participants

@xbaun @NetanelBasal