Skip to content

fix new cases with const and let #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanmcdermott merged 1 commit into from
Jan 9, 2017
Merged

fix new cases with const and let #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,11 +583,11 @@ Array.prototype.diff = function(comparisonArray) {
const values = [];
const hash = {};

for (let i of comparisonArray) {
for (const i of comparisonArray) {
hash[i] = true;
}

for (let i of this) {
for (const i of this) {
if (!hash[i]) {
values.push(i);
}
Expand All @@ -608,11 +608,11 @@ class SuperArray extends Array {
const values = [];
const hash = {};

for (let i of comparisonArray) {
for (const i of comparisonArray) {
hash[i] = true;
}

for (let i of this) {
for (const i of this) {
if (!hash[i]) {
values.push(i);
}
Expand Down Expand Up @@ -1150,12 +1150,12 @@ function renderLargeRectangles(rectangles) {
rectangles.forEach((rectangle) => {
rectangle.setWidth(4);
rectangle.setHeight(5);
let area = rectangle.getArea(); // BAD: Will return 25 for Square. Should be 20.
const area = rectangle.getArea(); // BAD: Will return 25 for Square. Should be 20.
rectangle.render(area);
})
}

let rectangles = [new Rectangle(), new Rectangle(), new Square()];
const rectangles = [new Rectangle(), new Rectangle(), new Square()];
renderLargeRectangles(rectangles);
```

Expand Down Expand Up @@ -1932,7 +1932,7 @@ class PerformanceReview {
}
}

let review = new PerformanceReview(user);
const review = new PerformanceReview(user);
review.perfReview();
```

Expand Down Expand Up @@ -1971,7 +1971,7 @@ class PerformanceReview {
}
}

let review = new PerformanceReview(employee);
const review = new PerformanceReview(employee);
review.perfReview();
```

Expand Down Expand Up @@ -2072,7 +2072,7 @@ proper indentation and formatting give the visual structure to your code.
////////////////////////////////////////////////////////////////////////////////
// Scope Model Instantiation
////////////////////////////////////////////////////////////////////////////////
const $scope.model = {
$scope.model = {
menu: 'foo',
nav: 'bar'
};
Expand All @@ -2087,7 +2087,7 @@ const actions = function() {

**Good**:
```javascript
const $scope.model = {
$scope.model = {
menu: 'foo',
nav: 'bar'
};
Expand Down