Skip to content

Simplify some code examples #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanmcdermott merged 5 commits into from
Jan 12, 2017
Merged

Simplify some code examples #65

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
465f3bf
use object shorthand notation
vsemozhetbyt Jan 7, 2017
7035841
remove default constructors
vsemozhetbyt Jan 7, 2017
14e83d5
use functional Array methods
vsemozhetbyt Jan 7, 2017
d7cc370
Merge branch 'master' into simplify
vsemozhetbyt Jan 8, 2017
d279012
Merge branch 'master' into simplify
vsemozhetbyt Jan 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 10 additions & 33 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,9 +378,9 @@ function showDeveloperList(developers) {
const experience = developer.getExperience();
const githubLink = developer.getGithubLink();
const data = {
expectedSalary: expectedSalary,
experience: experience,
githubLink: githubLink
expectedSalary,
experience,
githubLink
};

render(data);
Expand All @@ -393,9 +393,9 @@ function showManagerList(managers) {
const experience = manager.getExperience();
const portfolio = manager.getMBAProjects();
const data = {
expectedSalary: expectedSalary,
experience: experience,
portfolio: portfolio
expectedSalary,
experience,
portfolio
};

render(data);
Expand All @@ -417,9 +417,9 @@ function showList(employees) {
}

const data = {
expectedSalary: expectedSalary,
experience: experience,
portfolio: portfolio
expectedSalary,
experience,
portfolio
};

render(data);
Expand Down Expand Up @@ -600,25 +600,8 @@ Array.prototype.diff = function(comparisonArray) {
**Good:**
```javascript
class SuperArray extends Array {
constructor(...args) {
super(...args);
}

diff(comparisonArray) {
const values = [];
const hash = {};

for (const i of comparisonArray) {
hash[i] = true;
}

for (const i of this) {
if (!hash[i]) {
values.push(i);
}
}

return values;
return this.filter(elem => !comparisonArray.includes(elem));
}
}
```
Expand Down Expand Up @@ -1131,10 +1114,6 @@ class Rectangle {
}

class Square extends Rectangle {
constructor() {
super();
}

setWidth(width) {
this.width = width;
this.height = width;
Expand Down Expand Up @@ -1162,8 +1141,6 @@ renderLargeRectangles(rectangles);
**Good**:
```javascript
class Shape {
constructor() {}

setColor(color) {
// ...
}
Expand Down