Skip to content

make bad and old examples more comparable#124

Merged
ryanmcdermott merged 1 commit into
ryanmcdermott:masterfrom
vsemozhetbyt:diff
Jan 13, 2017
Merged

make bad and old examples more comparable#124
ryanmcdermott merged 1 commit into
ryanmcdermott:masterfrom
vsemozhetbyt:diff

Conversation

@vsemozhetbyt
Copy link
Copy Markdown
Contributor

See the comment of @ryanmcdermott.

With this PR:

  1. Bad and old examples become more comparable (let bad examples be bad only in regard to one appropriate case).
  2. Both examples do not contain type coercion (i.e. they use strict comparing).
  3. The new algorithm has less performance difference in small and large arrays comparing (some benchmarks have been done).

Also address performance concerns.
@ryanmcdermott ryanmcdermott merged commit a09a696 into ryanmcdermott:master Jan 13, 2017
@ryanmcdermott
Copy link
Copy Markdown
Owner

Even smaller, and probably faster time complexity! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants