Add an example to illustrate the join() method#116
Open
mortie wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most straightforward use of a thread pool is to execute some number of jobs, then wait for their completion. I had this need just now and reached for this crate, but I didn't realize that you could wait for all jobs to be done with the
join()method, so I went looking for a countdown latch crate instead.The barrier example sort of suggests that using some other syncronization primitive is a preferred way to wait for all jobs to be done. I think having a dedicated example to show the basic "spawn some workers then wait for them to complete" use case might help avoid confusion.