Repository navigation
Add some OpenSSL 3 QUIC raw bindings - #2257
Merged
Merged
Conversation
bdbai
marked this pull request as draft
July 3, 2024 09:08
bdbai
marked this pull request as ready for review
July 3, 2024 09:44
sfackler
reviewed
Jul 3, 2024
| unsafe extern "C" fn(*mut SSL, *mut c_int, *mut libc::c_void) -> i32, | ||
| >, | ||
| std::option::Option<unsafe extern "C" fn()>, | ||
| >(cb), |
Collaborator
There was a problem hiding this comment.
What is the purpose of this change?
Contributor
Author
There was a problem hiding this comment.
This is to address the clippy errors thrown during the first commit’s CI checks: https://github.com/sfackler/rust-openssl/actions/runs/9774772847/job/26983758164
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly focuses on
openssl-sysand raw bindings to OpenSSL 3 QUIC features that I think might be useful for implementing high-level, ergonomic QUIC bindings inopensslcrate. Also fixed some minor issues when usingbindgenfeature with Windows MSVC.Related: #2242