fix: update test script to work without lsof on CI#798
Open
jrvb-rl wants to merge 2 commits into
Open
Conversation
Use ss or fuser as fallbacks when lsof is not available, and warn gracefully if none are present. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When lsof, ss, and fuser are all unavailable, parse /proc/net/tcp to find socket inodes listening on the target port, then scan /proc/*/fd/ to map inodes back to pids. Always available on Linux. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We had one test which worked locally but failed reliably in the github CI environment due to lsof not being installed. This fix should get the CI tests back to green.
kill_server_on_portwhenlsofis unavailable (e.g. on GitHub Actions runners)ss, thenfuser, then parse/proc/net/tcpdirectly as a final fallbackTest plan
lsof)./scripts/teststill works on macOS (useslsofpath)🤖 Generated with Claude Code