Skip to content

perf(fmt): skip indexing stale cache files #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Aug 13, 2026
Merged

perf(fmt): skip indexing stale cache files #346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/rstack/src/fmt/cacheStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,10 @@ const createEmptyCache = (namespace: string): ParsedFmtCacheFile => ({
optionsUseCounts: [],
});

const parseCacheFile = (content: string): ParsedFmtCacheFile | undefined => {
const parseCacheFile = (
content: string,
expectedNamespace: string,
): ParsedFmtCacheFile | undefined => {
let value: unknown;
try {
value = JSON.parse(content);
Expand All @@ -73,7 +76,7 @@ const parseCacheFile = (content: string): ParsedFmtCacheFile | undefined => {
const { version, namespace, options, files } = cache;
if (
version !== fmtCacheVersion ||
typeof namespace !== 'string' ||
namespace !== expectedNamespace ||
!Array.isArray(options) ||
!Array.isArray(files) ||
files.length % fileEntryWidth !== 0
Expand Down Expand Up @@ -262,14 +265,12 @@ const loadFmtCacheStore = async (filePath: string, namespace: string): Promise<F

try {
const content = await readFile(filePath, 'utf8');
const parsed = parseCacheFile(content);
const parsed = parseCacheFile(content, namespace);
if (!parsed) {
return new FmtCacheStoreImpl(filePath, emptyCache, undefined, true);
}

return parsed.cache.namespace === namespace
? new FmtCacheStoreImpl(filePath, parsed, content, false)
: new FmtCacheStoreImpl(filePath, emptyCache, undefined, true);
return new FmtCacheStoreImpl(filePath, parsed, content, false);
} catch (error) {
const missing = isFileNotFoundError(error);
return new FmtCacheStoreImpl(filePath, emptyCache, undefined, !missing);
Expand Down