Skip to content

fix(fmt): skip malformed ignore patterns #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Aug 11, 2026
Merged

fix(fmt): skip malformed ignore patterns #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/rstack-ignore/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ impl SourceMatcher {
for line in source.patterns.split('\n') {
let line = line.strip_suffix('\r').unwrap_or(line);
let line = line.strip_prefix('\u{feff}').unwrap_or(line);
builder.add_line(None, line)?;
// Gitignore files and the previous JavaScript matcher treat malformed lines as
// nonmatching, while continuing to apply the remaining valid rules.
let _ = builder.add_line(None, line);
}

Ok(Self {
Expand Down
7 changes: 7 additions & 0 deletions packages/rstack/tests/fmt/ignore.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ test('matches gitignore patterns relative to the config root', async () => {
expect(isIgnored(path.join(rootPath, 'src/index.js'))).toBe(false);
});

test('skips malformed patterns without discarding valid patterns', async () => {
const isIgnored = await createMatcher(['ignored.js', 'malformed\\']);

expect(isIgnored(path.join(rootPath, 'ignored.js'))).toBe(true);
expect(isIgnored(path.join(rootPath, 'other.js'))).toBe(false);
});

test('distinguishes directory-only patterns from files', async () => {
const isIgnored = await createMatcher(['dist/']);
const directoryPath = path.join(rootPath, 'dist');
Expand Down